Added a missing method in the Constraint interface #182

Merged
merged 1 commit into from Aug 14, 2012

Projects

None yet

3 participants

@stof
Member
stof commented Aug 6, 2012

This adds a missing method in the Constraint interface. The method is already defined in AbstractAsset which is extended by both classes implementing the interface. the AbstractPlatform is calling this method on objects after checking they are implementing the interface. So either the method should be part of the interface, or all places using the interface as typehint should be refactored to check for the classes (examples can be found here and there).

Adding a method in an interface is technically a BC break but this method is not really a public extension point. what do you think @beberlei ?

@travisbot

This pull request fails (merged a56b5a2d into 4319165).

@travisbot

This pull request fails (merged fa0caab into 4319165).

@stof
Member
stof commented Aug 6, 2012

The failure is a travis issue when building the test environment in some of the builds

@asm89 asm89 merged commit 924a97e into doctrine:master Aug 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment