Skip to content

Added third an optional argument `types` to use prepared statement #186

Closed
wants to merge 3 commits into from

6 participants

@IgorTimoshenko

No description provided.

@travisbot

This pull request fails (merged 9159194a into e25c774).

@travisbot

This pull request fails (merged 9159194a into e25c774).

@beberlei beberlei commented on an outdated diff Aug 29, 2012
lib/Doctrine/DBAL/Connection.php
*/
- public function fetchColumn($statement, array $params = array(), $colnum = 0)
+ public function fetchColumn($sql, array $params = array(), array $types = array(), $colnum = 0)
@beberlei
Doctrine member
beberlei added a note Aug 29, 2012

please move $types to the end otherwise this is a BC break that i cannot merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@guilhermeblanco
Doctrine member

No CS issues from my side. =)
I also think the argument should be moved to the end

@IgorTimoshenko

I've done, check please.

@travisbot

This pull request fails (merged 527ee2a1 into e25c774).

@travisbot

This pull request fails (merged 527ee2a1 into e25c774).

@stof
Doctrine member
stof commented Aug 31, 2012

@timoshenko please fix the ConnectionMock

@travisbot

This pull request passes (merged 10aebd03 into e25c774).

@IgorTimoshenko

Will this pull request be merged? Thanks.

@stof
Doctrine member
stof commented Sep 16, 2012

@timoshenko please rebase your branch. It looks like you messed it.

@IgorTimoshenko

Fixed, can you check again?

@deeky666
Doctrine member

This is already in master.

@deeky666 deeky666 closed this Nov 21, 2013
@deeky666
Doctrine member

@IgorTimoshenko Sorry I confused this. It's not in master. Can you please reopen?

@stof
Doctrine member
stof commented Nov 23, 2013

@deeky666 when a repo collaborator closes a PR, only repo collaborators can click on the reopen button. So you have to do it. @IgorTimoshenko cannot (he could create a new one but this would split the discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.