Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Changed 'implements' by 'extends' on SQLAzureFederationsSynchronizer #189

Merged
merged 1 commit into from

4 participants

@mdaloia

This error was introduced with the changes commited on SHA: doctrine/dbal@12f381f

@mdaloia mdaloia Changed 'implements' by 'extends' because AbstractSchemaSynchronizer …
…is a class not an interface (and Eclipse PDT shows a warning that say that "The type SQLAzureFederationsSynchronizer must implement the inherited method processSqlSafely, processSql" but those methods are already implemented on AbstractSchemaSynchronizer).
4c95908
@stof

Looks like this class is totally untested :)

@travisbot

This pull request passes (merged 4c95908 into e25c774).

@travisbot

This pull request passes (merged 4c95908 into e25c774).

@guilhermeblanco guilhermeblanco merged commit bb88ba7 into doctrine:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 24, 2012
  1. @mdaloia

    Changed 'implements' by 'extends' because AbstractSchemaSynchronizer …

    mdaloia authored
    …is a class not an interface (and Eclipse PDT shows a warning that say that "The type SQLAzureFederationsSynchronizer must implement the inherited method processSqlSafely, processSql" but those methods are already implemented on AbstractSchemaSynchronizer).
This page is out of date. Refresh to see the latest.
View
2  lib/Doctrine/DBAL/Sharding/SQLAzure/SQLAzureFederationsSynchronizer.php
@@ -36,7 +36,7 @@
*
* @author Benjamin Eberlei <kontakt@beberlei.de>
*/
-class SQLAzureFederationsSynchronizer implements AbstractSchemaSynchronizer
+class SQLAzureFederationsSynchronizer extends AbstractSchemaSynchronizer
{
const FEDERATION_TABLE_FEDERATED = 'azure.federated';
const FEDERATION_DISTRIBUTION_NAME = 'azure.federatedOnDistributionName';
Something went wrong with that request. Please try again.