ExpressionBuilder in and notIn methods #192

Merged
merged 3 commits into from Aug 29, 2012

Conversation

Projects
None yet
4 participants
@paulchubatyy
Contributor

paulchubatyy commented Aug 27, 2012

ExpressionBuilder is missing in and not in methods to produce these statements.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 27, 2012

This pull request fails (merged aa4f09c into bb88ba7).

This pull request fails (merged aa4f09c into bb88ba7).

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 27, 2012

This pull request fails (merged aa4f09c into bb88ba7).

This pull request fails (merged aa4f09c into bb88ba7).

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Aug 27, 2012

Member

Please run your own tests when adding them :)

Member

stof commented Aug 27, 2012

Please run your own tests when adding them :)

@paulchubatyy

This comment has been minimized.

Show comment
Hide comment
@paulchubatyy

paulchubatyy Aug 28, 2012

Contributor

My bad, didn't have the environment set up completely on the new workstation.

Contributor

paulchubatyy commented Aug 28, 2012

My bad, didn't have the environment set up completely on the new workstation.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request passes (merged 802109c into bb88ba7).

This pull request passes (merged 802109c into bb88ba7).

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Aug 28, 2012

Member

Please revert the permission changes. These files have no reason to be executable.

If you are on windows, you should configure git to ignore the file mode as windows does not have filemode properly and so messes it

Member

stof commented Aug 28, 2012

Please revert the permission changes. These files have no reason to be executable.

If you are on windows, you should configure git to ignore the file mode as windows does not have filemode properly and so messes it

@paulchubatyy

This comment has been minimized.

Show comment
Hide comment
@paulchubatyy

paulchubatyy Aug 28, 2012

Contributor

@stof, thanks, didn't know how to fix that issue with file modes. And you're right, I'm currently on windows with cygwin so it drives me nuts.

Contributor

paulchubatyy commented Aug 28, 2012

@stof, thanks, didn't know how to fix that issue with file modes. And you're right, I'm currently on windows with cygwin so it drives me nuts.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Aug 28, 2012

This pull request passes (merged f812cc8 into bb88ba7).

This pull request passes (merged f812cc8 into bb88ba7).

beberlei added a commit that referenced this pull request Aug 29, 2012

Merge pull request #192 from Xobb/master
ExpressionBuilder in and notIn methods

@beberlei beberlei merged commit 3965d4f into doctrine:master Aug 29, 2012

1 check passed

default The Travis build passed
Details
@paulchubatyy

This comment has been minimized.

Show comment
Hide comment
@paulchubatyy

paulchubatyy Sep 12, 2012

Contributor

@beberlei this might be also backported to previous doctrine dbal versions.

Contributor

paulchubatyy commented Sep 12, 2012

@beberlei this might be also backported to previous doctrine dbal versions.

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Sep 13, 2012

Member

@xobb new features are not backported. This is the difference between minor releases and maintenance releases which only receive bugfixes

Member

stof commented Sep 13, 2012

@xobb new features are not backported. This is the difference between minor releases and maintenance releases which only receive bugfixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment