Skip to content

Add DBAL\TypeAwareObject. #193

Closed
wants to merge 1 commit into from

3 participants

@Romain-Geissler

This PR adds a common interface for custom object values that requires some PHP <-> SQL conversions, which allows to specify what DBAL type must be used for conversion.

@Romain-Geissler Romain-Geissler referenced this pull request in doctrine/doctrine2 Aug 29, 2012
Closed

Add DBAL\TypeAwareObject type inference. #432

@stof stof commented on the diff Aug 29, 2012
lib/Doctrine/DBAL/TypeAwareObject.php
@@ -0,0 +1,42 @@
+<?php
+/*
+ * $Id$
+ *
@stof
Doctrine member
stof added a note Aug 29, 2012

Tis SVN artifact should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof stof commented on the diff Aug 29, 2012
lib/Doctrine/DBAL/TypeAwareObject.php
+ * $Id$
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
@stof
Doctrine member
stof added a note Aug 29, 2012

this is wrong. DBAL switched to MIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof stof commented on the diff Aug 29, 2012
lib/Doctrine/DBAL/TypeAwareObject.php
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
@stof
Doctrine member
stof added a note Aug 29, 2012

this is wrong. new features won't be added in a bugfix release, and the phpdoc is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof stof commented on the diff Aug 29, 2012
lib/Doctrine/DBAL/TypeAwareObject.php
+ * and is licensed under the LGPL. For more information, see
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
+ * @version $Revision$
+ */
+
+interface TypeAwareObject{
@stof
Doctrine member
stof added a note Aug 29, 2012

the curly brace should be on its own line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof stof commented on the diff Aug 29, 2012
lib/Doctrine/DBAL/TypeAwareObject.php
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
+ * @version $Revision$
+ */
+
@stof
Doctrine member
stof added a note Aug 29, 2012

the empty line between the phpdoc and the declaration should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@travisbot

This pull request passes (merged 14d6a8c into 24ec194).

@travisbot

This pull request passes (merged 14d6a8c into 24ec194).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.