Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add DBAL\TypeAwareObject. #193

Closed
wants to merge 1 commit into from

3 participants

Romain Geissler Don't Add Me To Your Organization a.k.a The Travis Bot Christophe Coevoet
Romain Geissler

This PR adds a common interface for custom object values that requires some PHP <-> SQL conversions, which allows to specify what DBAL type must be used for conversion.

Romain Geissler Romain-Geissler referenced this pull request in doctrine/doctrine2
Closed

Add DBAL\TypeAwareObject type inference. #432

Christophe Coevoet stof commented on the diff
lib/Doctrine/DBAL/TypeAwareObject.php
@@ -0,0 +1,42 @@
+<?php
+/*
+ * $Id$
+ *
Christophe Coevoet
stof added a note

Tis SVN artifact should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Christophe Coevoet stof commented on the diff
lib/Doctrine/DBAL/TypeAwareObject.php
((3 lines not shown))
+ * $Id$
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
Christophe Coevoet
stof added a note

this is wrong. DBAL switched to MIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Christophe Coevoet stof commented on the diff
lib/Doctrine/DBAL/TypeAwareObject.php
((14 lines not shown))
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
Christophe Coevoet
stof added a note

this is wrong. new features won't be added in a bugfix release, and the phpdoc is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Christophe Coevoet stof commented on the diff
lib/Doctrine/DBAL/TypeAwareObject.php
((18 lines not shown))
+ * and is licensed under the LGPL. For more information, see
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
+ * @version $Revision$
+ */
+
+interface TypeAwareObject{
Christophe Coevoet
stof added a note

the curly brace should be on its own line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Christophe Coevoet stof commented on the diff
lib/Doctrine/DBAL/TypeAwareObject.php
((17 lines not shown))
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
+ * @version $Revision$
+ */
+
Christophe Coevoet
stof added a note

the empty line between the phpdoc and the declaration should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 14d6a8c into 24ec194).

Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 14d6a8c into 24ec194).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 29, 2012
  1. Romain Geissler
This page is out of date. Refresh to see the latest.
Showing with 42 additions and 0 deletions.
  1. +42 −0 lib/Doctrine/DBAL/TypeAwareObject.php
42 lib/Doctrine/DBAL/TypeAwareObject.php
View
@@ -0,0 +1,42 @@
+<?php
+/*
+ * $Id$
+ *
Christophe Coevoet
stof added a note

Tis SVN artifact should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * This software consists of voluntary contributions made by many individuals
+ * and is licensed under the LGPL. For more information, see
Christophe Coevoet
stof added a note

this is wrong. DBAL switched to MIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ * <http://www.doctrine-project.org>.
+ */
+
+namespace Doctrine\DBAL;
+
+/**
+ * Interface for SQL loggers.
+ *
+ * @license http://www.opensource.org/licenses/lgpl-license.php LGPL
+ * @link www.doctrine-project.org
+ * @since 2.2.3
Christophe Coevoet
stof added a note

this is wrong. new features won't be added in a bugfix release, and the phpdoc is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ * @version $Revision$
+ */
+
Christophe Coevoet
stof added a note

the empty line between the phpdoc and the declaration should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+interface TypeAwareObject{
Christophe Coevoet
stof added a note

the curly brace should be on its own line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ /**
+ * Return DBAL type of this object, it must a compatible constant:
+ * - Type (\Doctrine\DBAL\Types\Type::*)
+ * - Connection (\Doctrine\DBAL\Connection::PARAM_*)
+ *
+ * @return mixed This object type constant
+ */
+ public function getDBALType();
+}
Something went wrong with that request. Please try again.