params not passed from execute to logger #200

Merged
merged 4 commits into from Sep 17, 2012

Conversation

Projects
None yet
4 participants
Contributor

robap commented Sep 16, 2012

When parameters are passed to Doctrine\DBAL\Statement::execute, they are not passed to any enabled logger(s).

tests/Doctrine/Tests/DBAL/StatementTest.php
+use Doctrine\DBAL\Statement;
+//use Doctrine\Common\EventManager;
+//use Doctrine\DBAL\Configuration;
+//use Doctrine\DBAL\Events;
@stof

stof Sep 16, 2012

Member

please remove these commented use statements

tests/Doctrine/Tests/DBAL/StatementTest.php
+
+namespace Doctrine\Tests\DBAL;
+
+require_once __DIR__ . '/../TestInit.php';
@stof

stof Sep 16, 2012

Member

This line is not needed anymore

lib/Doctrine/DBAL/Statement.php
@@ -129,6 +129,10 @@ public function bindParam($name, &$var, $type = PDO::PARAM_STR, $length = null)
*/
public function execute($params = null)
{
+ if(is_array($params)) {
@guilhermeblanco

guilhermeblanco Sep 16, 2012

Owner

Missing space between if and open parenthesis

beberlei added a commit that referenced this pull request Sep 17, 2012

Merge pull request #200 from robap/master
params not passed from execute to logger

@beberlei beberlei merged commit a012705 into doctrine:master Sep 17, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment