Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed DBAL-139 Oracle's sequences with NOCACHE #202

Merged
merged 0 commits into from Sep 22, 2012

Conversation

Projects
None yet
2 participants
@ghost
Contributor

ghost commented Sep 22, 2012

No description provided.

@ghost ghost closed this Sep 22, 2012

@ghost ghost reopened this Sep 22, 2012

@stof stof commented on an outdated diff Sep 22, 2012

@@ -4,3 +4,7 @@ reports/
dist/
download/
lib/Doctrine/Common/
+.project
+.buildpath
+.settings/
+
@stof

stof Sep 22, 2012

Member

Please remove this as it is not tied to the project but to your own setup. You should ignore it on your machine only (and it can even be done globally to avoid redoing it for each project): https://help.github.com/articles/ignoring-files

Btw, github maintains a repo with common gitignore files, and one of them is the Eclipse one

@stof stof commented on an outdated diff Sep 22, 2012

lib/Doctrine/DBAL/Schema/Sequence.php
- */
+* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+*
+* This software consists of voluntary contributions made by many individuals
+* and is licensed under the MIT license. For more information, see
+* <http://www.doctrine-project.org>.
+*/
@stof

stof Sep 22, 2012

Member

Please revert this indentation change

@stof stof commented on an outdated diff Sep 22, 2012

lib/Doctrine/DBAL/Schema/Sequence.php
+ */
+ protected $_initialValue = 1;
+
+ /**
+ * @var string
+ */
+ protected $_cacheSize;
+
+ /**
+ *
+ * @param string $name
+ * @param int $allocationSize
+ * @param int $initialValue
+ * @param string $cacheSize
+ */
+ public function __construct($name, $allocationSize=1, $initialValue=1, $cacheSize = 20)
@stof

stof Sep 22, 2012

Member

Please don't change the indentation in the file

@stof

stof Sep 22, 2012

Member

note that we are using spaces

Member

stof commented Sep 22, 2012

Btw, it looks weird to me that no test is changed in the testsuite

@ghost ghost merged commit 804bd86 into doctrine:master Sep 22, 2012

@ghost
Contributor

ghost commented Sep 22, 2012

You are right, no matter how trivial this is test should be made and written.
Will write the tests and request pull again some other day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment