Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed DBAL-139 Oracle's sequences with NOCACHE #202

Merged
merged 0 commits into from

2 participants

@AduroIdea

No description provided.

@AduroIdea AduroIdea closed this
@AduroIdea AduroIdea reopened this
.gitignore
@@ -4,3 +4,7 @@ reports/
dist/
download/
lib/Doctrine/Common/
+.project
+.buildpath
+.settings/
+
@stof
stof added a note

Please remove this as it is not tied to the project but to your own setup. You should ignore it on your machine only (and it can even be done globally to avoid redoing it for each project): https://help.github.com/articles/ignoring-files

Btw, github maintains a repo with common gitignore files, and one of them is the Eclipse one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
lib/Doctrine/DBAL/Schema/Sequence.php
((18 lines not shown))
- */
+* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+*
+* This software consists of voluntary contributions made by many individuals
+* and is licensed under the MIT license. For more information, see
+* <http://www.doctrine-project.org>.
+*/
@stof
stof added a note

Please revert this indentation change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
lib/Doctrine/DBAL/Schema/Sequence.php
((96 lines not shown))
+ */
+ protected $_initialValue = 1;
+
+ /**
+ * @var string
+ */
+ protected $_cacheSize;
+
+ /**
+ *
+ * @param string $name
+ * @param int $allocationSize
+ * @param int $initialValue
+ * @param string $cacheSize
+ */
+ public function __construct($name, $allocationSize=1, $initialValue=1, $cacheSize = 20)
@stof
stof added a note

Please don't change the indentation in the file

@stof
stof added a note

note that we are using spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof

Btw, it looks weird to me that no test is changed in the testsuite

@AduroIdea AduroIdea merged commit 804bd86 into doctrine:master
@AduroIdea

You are right, no matter how trivial this is test should be made and written.
Will write the tests and request pull again some other day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 0 deletions.
Something went wrong with that request. Please try again.