Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Removed Unsigned Integer Support in SQL Server #207

Merged
merged 1 commit into from almost 2 years ago

4 participants

Daniel Anderson Tiecher doctrinebot Coveralls Benjamin Eberlei
Daniel Anderson Tiecher

Removed unsigned integer test as SQL Server doesn't support unsigned integers.

doctrinebot
Collaborator

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-354

Benjamin Eberlei beberlei merged commit c7516d4 into from
Coveralls

Coverage Status

Changes Unknown when pulling fbc2f53 on datiecher:master into ** on doctrine:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Sep 28, 2012
Daniel Anderson Tiecher datiecher Removed unsigned integer test as SQL Server doesn't support unsigned …
…integers.
fbc2f53
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 7 deletions. Show diff stats Hide diff stats

  1. +1 7 lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
8 lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
@@ -631,13 +631,7 @@ public function getClobTypeDeclarationSQL(array $field)
631 631 */
632 632 protected function _getCommonIntegerTypeDeclarationSQL(array $columnDef)
633 633 {
634   - $autoinc = '';
635   - if (!empty($columnDef['autoincrement'])) {
636   - $autoinc = ' IDENTITY';
637   - }
638   - $unsigned = (isset($columnDef['unsigned']) && $columnDef['unsigned']) ? ' UNSIGNED' : '';
639   -
640   - return $unsigned . $autoinc;
  634 + return (!empty($columnDef['autoincrement'])) ? ' IDENTITY' : '';
641 635 }
642 636
643 637 /**

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.