The "bindParam" method of OCI8Statement is not using the "length" parameter #214

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

theUniC commented Oct 6, 2012

I've fixed the OCI8Statement::bindParam method in order to pass the "length" parameter when the type is not a LOB

https://github.com/doctrine/dbal/blob/master/lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php#L112

As noted on the description of the function on the PHP manual (for the IN binds), this is leading to a truncation of the values to the size of the PHP variable.

http://www.php.net/manual/en/function.oci-bind-by-name.php

Christian Fixed the "bindParameter" method on the OCI8Statement class to correc…
…tly pass the "length" parameter to the "oci_bind_by_name" function when the type isn't a PDO::PARAM_LOB.
4bc7c7f

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-362

Hi guys,

I have the same issue, this commit fix the problem perfectly.

Owner

beberlei commented May 9, 2013

This was added in another PR

beberlei closed this May 9, 2013

Coverage Status

Changes Unknown when pulling 4bc7c7f on Emagister:master into * on doctrine:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment