Fixed SQL placeholder parsing #216

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

a-nik commented Oct 11, 2012

Fixed comment on 'getPlaceholderPositions' method
Fixed error on escaped quote mark inside an SQL expression

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-364

Contributor

avit commented Dec 9, 2012

Possibly a duplicate of my pull request? #113

Relevant ticket here, they partly fixed something but the parsing was still broken: http://www.doctrine-project.org/jira/browse/DBAL-231

My pull request has been sitting there since March when I rebased it on master for them. I don't think they look for contributions here on Github.

Owner

beberlei commented Jan 6, 2013

Closing in favor of GH-113

beberlei closed this Jan 6, 2013

Owner

beberlei commented Jan 6, 2013

@avit we do, but some PRs are quite "big" in the scope that you cannot just merge them without investing some hours of evaluation, which we sometimes not have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment