[MySQL] Fixed bug with comments not adding quotes for tables #218

Merged
merged 1 commit into from Oct 15, 2012

Conversation

Projects
None yet
5 participants
Contributor

okovalov commented Oct 11, 2012

Title describes everything... =)

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-366

Contributor

okovalov commented Oct 11, 2012

Failure is due to Travis unable to install build-common.

Member

stof commented Oct 11, 2012

What if the comment contains a quote ?

Owner

beberlei commented Oct 12, 2012

werd, is this untested in DBAL?

Member

stof commented Oct 12, 2012

@beberlei btw, it would be great to fix the DBAL testsuite. Having a failing testsuite does not help to know if the PR broke something else or no.

Owner

beberlei commented Oct 12, 2012

oh didnt see it was broken, will fix

Owner

beberlei commented Oct 12, 2012

looks good to me when i see the history?

guilhermeblanco added a commit that referenced this pull request Oct 15, 2012

Merge pull request #218 from okovalov/master
[MySQL] Fixed bug with comments not adding quotes for tables

@guilhermeblanco guilhermeblanco merged commit d56c9fe into doctrine:master Oct 15, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment