[MySQL] Fixed bug with comments not adding quotes for tables #218

Merged
merged 1 commit into from Oct 15, 2012

5 participants

@okovalov

Title describes everything... =)

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-366

@okovalov

Failure is due to Travis unable to install build-common.

@stof
Doctrine member

What if the comment contains a quote ?

@beberlei
Doctrine member

werd, is this untested in DBAL?

@stof
Doctrine member

@beberlei btw, it would be great to fix the DBAL testsuite. Having a failing testsuite does not help to know if the PR broke something else or no.

@beberlei
Doctrine member

oh didnt see it was broken, will fix

@beberlei
Doctrine member

looks good to me when i see the history?

@guilhermeblanco guilhermeblanco merged commit d56c9fe into doctrine:master Oct 15, 2012

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment