DBAL-398: Do not treat assignment operator as a parameter #237

Merged
merged 3 commits into from Dec 22, 2012

Conversation

Projects
None yet
3 participants
Contributor

roverwolf commented Dec 18, 2012

A native (mysql) query should be able to use the assignment operator := but currently the SQLParserUtils method treats that as a missing parameter.

The patch solves the issue, but it looks like a higher-level fix might be desired that also handles the regular expression better.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-399

Contributor

roverwolf commented Dec 18, 2012

There doesn't seem to be a way to kick Travis, it shows a failed build but all sub-builds passed except for one where the logs show that pgsql took too long to create the database.

beberlei added a commit that referenced this pull request Dec 22, 2012

Merge pull request #237 from roverwolf/DBAL-398
DBAL-398: Do not treat assignment operator as a parameter

@beberlei beberlei merged commit 2802d88 into doctrine:master Dec 22, 2012

1 check failed

default The Travis build failed
Details

@roverwolf roverwolf deleted the roverwolf:DBAL-398 branch Mar 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment