Added GUID expression to SQLite platform #253

Merged
merged 2 commits into from Jan 25, 2013

Projects

None yet

5 participants

@jankramer
Contributor

This will add an implementation of getGuidExpression to the SqlitePlatform. It is based on UUID version 4.

Don't know if this is appropriate, but I'm open to suggestions.

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-421

@guilhermeblanco
Member

Can you add a test for that?

@jankramer
Contributor

@guilhermeblanco I added a (functional) test case that provides a check on the pattern and a (basic) check on the uniqueness of the GUID.

@guilhermeblanco guilhermeblanco merged commit 1926921 into doctrine:master Jan 25, 2013

1 check passed

default The Travis build passed
Details
@till
Contributor
till commented Jun 26, 2013

@guilhermeblanco Is this gonna be in 2.3.x? We just ran into this problem.

@coveralls

Coverage Status

Changes Unknown when pulling 1bba751 on jankramer:add-sqlite-guid into * on doctrine:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment