Fix OFFSET without LIMIT cause MySQL syntax error. #261

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
6 participants
Contributor

Everus commented Jan 29, 2013

MySQL OFFSET require LIMIT.
So fixed it to use the biggest limit possible as it recommended in http://dev.mysql.com/doc/refman/5.0/en/select.html#id4651990

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-431

Owner

Ocramius commented Jan 29, 2013

@Everus what's the failing test case for this one?

Member

stof commented Jan 29, 2013

This is wrong. It does not add the offset anymore when the limit is not null

Contributor

Everus commented Jan 31, 2013

I can't see what wrong in it, maybe you can point me in right direction.

Member

stof commented Jan 31, 2013

hmm, sorry.

However, as this fix is only for MySQL, I think it should be done in the MySQLPlatform only

Owner

beberlei commented Apr 14, 2013

Fixed in 3f220a1

beberlei closed this Apr 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment