DBAL-446 #276

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@nemekzg
nemekzg commented Feb 19, 2013

Fix for DBAL-446 with a proper test case and two general test cases.

@doctrinebot

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-451

@stof stof commented on an outdated diff Feb 19, 2013
tests/Doctrine/Tests/DBAL/Types/JsonArrayTest.php
@@ -0,0 +1,41 @@
+<?php
+
+namespace Doctrine\Tests\DBAL\Types;
+
+use Doctrine\DBAL\Types\Type;
+
+require_once __DIR__ . '/../../TestInit.php';
@stof
stof Feb 19, 2013 Member

This line is useless (this file is already the PHPUnit bootstrap file) so you should remove it.

@stof stof commented on an outdated diff Feb 19, 2013
tests/Doctrine/Tests/DBAL/Types/JsonArrayTest.php
@@ -0,0 +1,41 @@
+<?php
+
+namespace Doctrine\Tests\DBAL\Types;
+
+use Doctrine\DBAL\Types\Type;
+
+require_once __DIR__ . '/../../TestInit.php';
+
+class JsonArrayTest extends \Doctrine\Tests\DbalTestCase
+{
+ protected
+ $_platform,
+ $_type;
@stof
stof Feb 19, 2013 Member

Please use 2 declarations and remove the leading _

@beberlei
Member
beberlei commented Apr 6, 2013

This was fixed already

@beberlei beberlei closed this Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment