Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

adds new output format #279

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Member

schmittjoh commented Mar 3, 2013

The output of the ::dump method is very unstable (depends on platform/PHP version/installed extensions).

This pull request adds a new format which is more suitable for machine consumption.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-456

@schmittjoh schmittjoh referenced this pull request in doctrine/doctrine2 Mar 3, 2013

Closed

adds a new output format #598

@Majkl578 Majkl578 commented on the diff Mar 3, 2013

...Doctrine/DBAL/Tools/Console/Command/RunSqlCommand.php
- $output->write($message);
+ $output->write($message);
+ break;
+
+ case 'jms-serializer-json':
+ $serializer = SerializerBuilder::create()->build();
@Majkl578

Majkl578 Mar 3, 2013

Member

This class is not part of DBAL. It's also not pulled by composer, since it's not in require or suggest sections. This will just fail if someone uses this.

@schmittjoh

schmittjoh Mar 3, 2013

Member

You're right, this will fail when the library is not required as part of the root project's composer.json.

We should probably add it to the suggest section.

@stof

stof Mar 3, 2013

Member

it should indeed be added in the suggest section

Member

schmittjoh commented Mar 4, 2013

Closing as per discussion on the related PR.

@schmittjoh schmittjoh closed this Mar 4, 2013

@schmittjoh schmittjoh deleted the schmittjoh:newOutputFormat branch Mar 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment