This PR optimizes the AbstractPlatform class in the following ways:
I hope this is a welcomed improvement. It reads much better now and feels somewhat cleaner to me.
thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:
You removed some information form the phpdoc in getListTableIndexesSQL and getDefaultTransactionIsolationLevel (the fact that it returns one of the constants).
And you should also revert the change from elseif to else if. We are writing it without space
Readded the important information in phpDocs and fixed else if CS.
BTW are the Doctrine coding standards written down anywhere? Or is there even a PHPCS template available for download?
We follow Symfony2 Coding standards, but we made a strict decision to choose ! as an operator (which requires spaces around it).
Also, we follow and advocate Object Calisthenics as much as we can as long as it doesn't degrade performance.
The part that we don't have clear agreement is about Abstract classes and Interfaces.
Some like to prefix with Abstract or suffix with Interfaces... others consider it shouldn't have class modifiers into their names.
Until we clear this, we stick to Symfony2 coding standards. =)
I'm pro do not suffix or prefix, fyi...
Hey thanks for clearing this up =). I guessed that Doctrine tries to go along with Symfony2 coding standards but I wasn't sure about the specific differences.
@deeky666 Can you rebase the PR? With 2.4 out we now have capacity for all your pending PRs :-)
optimize AbstractPlatform phpDocs
optimize code fragments and CS
fix more typos in phpDocs
fix create index SQL
readd some important information to phpDocs
fix else if CS
fix rebase problem
@beberlei great to hear that 2.4 is out! I have rebased this PR.
Closing as rebase is too much effort at this point.