check for proper type when formatting dates #297

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants

No description provided.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DBAL-481

Owner

Ocramius commented Apr 2, 2013

@mprzytulski this will just silently fail for people with invalid type-hints, which is worse than just having it crash with some valid failure message. 👎

Member

kimhemsoe commented Apr 2, 2013

Agree with @Ocramius that a crash is better then silent fail.

Member

stof commented Apr 2, 2013

Setting the value to null when the field contains an invalid value is indeed a bad idea. It is not even a silent fail but a bug IMO.

Owner

beberlei commented Apr 2, 2013

Closing

beberlei closed this Apr 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment