Changed property visibility to protected #321

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@barnabywalters

The main reason being to allow QueryBuilder to be subclassed — for example so that we can fix issues like problematic shallow cloning locally and use them without having to wait for a pull request to be merged.

Changed property visibility to protected
The main reason being to allow QueryBuilder to be subclassed — for example so that we can fix issues like problematic shallow cloning locally and use them without having to wait for a pull request to be merged.
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof May 20, 2013

Member

Changing the visibility of all these properties means that they become extension points for which we then must provide BC until 3.0 according to our guidelines. So IMO, it is a -1 here.

Member

stof commented May 20, 2013

Changing the visibility of all these properties means that they become extension points for which we then must provide BC until 3.0 according to our guidelines. So IMO, it is a -1 here.

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius May 20, 2013

Member

@barnabywalters the QueryBuilder is already very complex - as @stof said, you're also locking it from being changed internally, and that's problematic right now, since internal refactorings can happen quite often because of its complexity.

Member

Ocramius commented May 20, 2013

@barnabywalters the QueryBuilder is already very complex - as @stof said, you're also locking it from being changed internally, and that's problematic right now, since internal refactorings can happen quite often because of its complexity.

@Ocramius Ocramius closed this May 20, 2013

@barnabywalters

This comment has been minimized.

Show comment
Hide comment
@barnabywalters

barnabywalters May 20, 2013

Understood, thanks for the explanations :)

Understood, thanks for the explanations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment