Fix foreign table name quotation in schema table and Sqlite platform #338

Merged
merged 1 commit into from Jun 21, 2013

Conversation

Projects
None yet
2 participants
@deeky666
Member

deeky666 commented Jun 18, 2013

This fixes a bug introduced in PR #302 where the foreign table name did not get properly quoted in some circumstances.

@@ -80,7 +82,13 @@ public function __construct(array $localColumnNames, $foreignTableName, array $f
$this->_localColumnNames = $localColumnNames
? array_combine($localColumnNames, array_map($identifierConstructorCallback, $localColumnNames))
: array();
- $this->_foreignTableName = new Identifier($foreignTableName);
+
+ if ($foreignTableName instanceof Table) {

This comment has been minimized.

Show comment Hide comment
@beberlei

beberlei Jun 19, 2013

Member

this looks wrong, don't you need to save the identifier and not the Table?

@beberlei

beberlei Jun 19, 2013

Member

this looks wrong, don't you need to save the identifier and not the Table?

This comment has been minimized.

Show comment Hide comment
@deeky666

deeky666 Jun 19, 2013

Member

The functionality is the same in the end but it is cleaner with your suggestion, that's true. I'll change that.

EDIT:
Hmm your way I would have to know the platform again because I need to store the quoted foreign table name from the Table instance in the asset identifier. :(

@deeky666

deeky666 Jun 19, 2013

Member

The functionality is the same in the end but it is cleaner with your suggestion, that's true. I'll change that.

EDIT:
Hmm your way I would have to know the platform again because I need to store the quoted foreign table name from the Table instance in the asset identifier. :(

beberlei added a commit that referenced this pull request Jun 21, 2013

Merge pull request #338 from deeky666/fix-asset-identfier-quotation
Fix foreign table name quotation in schema table and Sqlite platform

@beberlei beberlei merged commit 4804a9a into doctrine:master Jun 21, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment