AbstractPlatform::getIdentityColumnNullInsertSQL() is not used anywhere, probably a leftover.
Removing a public method is technically a BC break (even if I doubt someone actually rely on it given its behavior)
Yes, given its null behaviour and its isolation, I doubt it would. Also, because 2.4 is currently in RC, that would be a good time to remove it?
@BenMorel is it a new method in 2.4 or is it part of a previous stable release ?
If it is new, we can indeed remove it. Otherwise, it would have to wait until 3.0 because of BC concerns
@stof It's definitely not new, it's been introduced in 2009, but seemingly never used. I understand your concerns though. What about the next release, 2.5, if any? In the meantime, I will change this PR to mark it @deprecated.
@BenMorel waiting 1 more release would still be a BC break. And when following semver, a BC rbeak means bumping the major version. It is not worth it just to remove an unused method IMO.
Ok no worries, I thought BC breaks were OK with minor version!
@BenMorel more information about semver: http://semver.org/
Marked an unused method as deprecated in AbstractPlatform.
@gwis @stof Ok, following the semver standard, the method should be deprecated in at least one minor version, before being removed in the next major version. I've updated the PR, we would need to integrate it in 2.4 or 2.5 then!