New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider column lengths when comparing indices #3415

Merged
merged 1 commit into from Dec 27, 2018

Conversation

Projects
None yet
3 participants
@morozov
Copy link
Member

morozov commented Dec 19, 2018

Q A
Type bug

When comparing indices, compare column lengths as well. Fixes #3414.

@morozov

This comment has been minimized.

Copy link
Member

morozov commented Dec 19, 2018

Not sure how this is supposed to work when the target platform doesn't support index lengths but they are specified in the metadata. Something should remove lengths from the target definitions in order to avoid the diff which is impossible to eliminate.

@morozov morozov requested a review from Ocramius Dec 22, 2018

@Ocramius
Copy link
Member

Ocramius left a comment

👍

@morozov morozov merged commit df4071e into doctrine:master Dec 27, 2018

4 checks passed

Scrutinizer Analysis: 3 updated code elements – Tests: passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuousphp Build passed successfully on continuousphp.
Details

@morozov morozov deleted the morozov:issues/3414 branch Dec 27, 2018

morozov added a commit that referenced this pull request Dec 27, 2018

@leofeyer

This comment has been minimized.

Copy link
Contributor

leofeyer commented Dec 28, 2018

Thank you @morozov. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment