HHVM compatibility: func_get_args #372

Merged
merged 1 commit into from Sep 15, 2013

Conversation

Projects
None yet
4 participants
Contributor

javer commented Sep 15, 2013

All func_get_args() calls have been moved to the top of the methods because HHVM doesn't keep a copy of the original args for performance reasons.

See facebook/hiphop-php#1027 for details.

HHVM compatibility: func_get_args
All func_get_args() calls have been moved to the top of the methods
because HHVM doesn't keep a copy of the original args for performance
reasons.

See facebook/hhvm#1027 for details.

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-608

We use Jira to track the state of pull requests and the versions they got
included in.

guilhermeblanco added a commit that referenced this pull request Sep 15, 2013

Merge pull request #372 from javer/hhvm-func_get_args
HHVM compatibility: func_get_args

@guilhermeblanco guilhermeblanco merged commit 8f119ee into doctrine:master Sep 15, 2013

1 check passed

default The Travis CI build passed
Details

@deeky666 deeky666 added this to the 2.5 milestone Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment