Fix Index construction #386

Merged
merged 1 commit into from Oct 9, 2013

Conversation

Projects
None yet
3 participants
@deeky666
Member

deeky666 commented Oct 9, 2013

This PR fixes an uncommon but possible use case where an Index is constructed with an empty columns array. Following calls to Index::getColumns() lead to a PHP warning array_keys() expects parameter 1 to be array, null given as the $_columns property is not properly initialized.

@doctrinebot

This comment has been minimized.

Show comment
Hide comment
@doctrinebot

doctrinebot Oct 9, 2013

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-626

We use Jira to track the state of pull requests and the versions they got
included in.

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-626

We use Jira to track the state of pull requests and the versions they got
included in.

guilhermeblanco added a commit that referenced this pull request Oct 9, 2013

@guilhermeblanco guilhermeblanco merged commit a619261 into doctrine:master Oct 9, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment