DBAL-645: Oracle Platform: Cannot list table columns from a different schema #396

Merged
merged 1 commit into from Nov 2, 2013

Conversation

Projects
None yet
3 participants
@darkindex
Contributor

darkindex commented Oct 30, 2013

http://www.doctrine-project.org/jira/browse/DBAL-645

Using user_col_comments in the INNER JOIN when referencing all_tab_columns causes no results to be returned.

Changed query to reference all_col_comments when referencing a different $database

@doctrinebot

This comment has been minimized.

Show comment Hide comment
@doctrinebot

doctrinebot Oct 30, 2013

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-646

We use Jira to track the state of pull requests and the versions they got
included in.

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-646

We use Jira to track the state of pull requests and the versions they got
included in.

$ownerCondition = "AND c.owner = '".$database."'";
}
return "SELECT c.*, d.comments FROM $tabColumnsTableName c ".
- "INNER JOIN user_col_comments d ON d.TABLE_NAME = c.TABLE_NAME AND d.COLUMN_NAME = c.COLUMN_NAME ".
+ "INNER JOIN ".$colCommentsTableName." d ON d.TABLE_NAME = c.TABLE_NAME AND d.COLUMN_NAME = c.COLUMN_NAME ".

This comment has been minimized.

Show comment Hide comment
@deeky666

deeky666 Nov 2, 2013

Member

Please put spaces around . when concatenating strings.

@deeky666

deeky666 Nov 2, 2013

Member

Please put spaces around . when concatenating strings.

@darkindex

This comment has been minimized.

Show comment Hide comment
@darkindex

darkindex Nov 2, 2013

Contributor

@deeky666 I've changed the one I added (but left the others in the statement alone). Is it best to squash these 2 commits together?

Contributor

darkindex commented Nov 2, 2013

@deeky666 I've changed the one I added (but left the others in the statement alone). Is it best to squash these 2 commits together?

@deeky666

This comment has been minimized.

Show comment Hide comment
@deeky666

deeky666 Nov 2, 2013

Member

@darkindex yes, please :) The PR is fine and can be merged afterwards. Thanks.

Member

deeky666 commented Nov 2, 2013

@darkindex yes, please :) The PR is fine and can be merged afterwards. Thanks.

Use all_col_comments when specifying a $database for getListTableColu…
…mnsSQL()

Using user_col_comments in the INNER JOIN when referencing all_tab_columns causes no results to be returned.

deeky666 added a commit that referenced this pull request Nov 2, 2013

Merge pull request #396 from darkindex/DBAL-645
DBAL-645: Oracle Platform: Cannot list table columns from a different schema

@deeky666 deeky666 merged commit f84d442 into doctrine:master Nov 2, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment