Fix string quoting for OCI8 driver #438

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@skolodyazhnyy

The Oracle database doesn't require escaping \ between single quotes, so if you pass 'A\B' into query it will be stored with double slash. I have remove \ from the list of the symbols which need to be escaped.

@skolodyazhnyy skolodyazhnyy Fix string quoting for OCI8 driver
The Oracle database doesn't require escaping \ between single quotes, so if you pass 'A\\B' into query it will be stored with double slash. I have remove \ from the list of the symbols which need to be escaped.
6dec897
@doctrinebot

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-696

We use Jira to track the state of pull requests and the versions they got
included in.

@beberlei
Member

@skolodyazhnyy I don't feel good merging this without proof as a test-case, I cannot verify from my end that this is not causing a security problem.

@skolodyazhnyy

Ok, agree. It seems default escape symbol is not a backslash for my server. Will come up with better solution.

@beberlei beberlei closed this Dec 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment