Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-4510] Deprecate ReservedWordsCommand::setKeywordListClass() #4587

Merged
merged 1 commit into from Apr 5, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 4, 2021

Q A
Type deprecation
BC Break no

See #4510.

The usage of ReservedWordsCommand::setKeywordListClass() is being deprecated in favor of setKeywordList(). This way, the DBAL will be no longer responsible for unsafe instantiation of classes with unknown constructor signature.

Additionally, the list of keyword lists has been sorted alphabetically and the command help message has been corrected: all keyword lists are used by default including the IBM DB2 list.

@morozov morozov added this to the 3.1.0 milestone Apr 4, 2021
@morozov morozov linked an issue Apr 4, 2021 that may be closed by this pull request
@morozov morozov marked this pull request as ready for review Apr 4, 2021
@morozov morozov requested a review from greg0ire Apr 4, 2021
@morozov morozov merged commit 5fb6543 into doctrine:3.1.x Apr 5, 2021
48 checks passed
@morozov morozov deleted the issues/4510 branch Apr 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants