Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect type coverage metrics, add badge to README #4604

Merged
merged 2 commits into from Apr 17, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Apr 15, 2021

Q A
Type improvement
BC Break no

Just another code quality metric which unlike code coverage should be green.

@morozov
Copy link
Member Author

morozov commented Apr 15, 2021

According to psalm/shepherd#6 (comment), type coverage will be only collected once the psalm configuration gets merged into the default branch.

@morozov morozov requested a review from greg0ire Apr 17, 2021
README.md Show resolved Hide resolved
@morozov morozov merged commit 9fc431a into doctrine:2.13.x Apr 17, 2021
49 checks passed
@morozov morozov deleted the shepherd branch Apr 17, 2021
@morozov
Copy link
Member Author

morozov commented Apr 17, 2021

Almost correct. I forgot that the default branch is 3.1.x, not 2.13.x.

I temporarily switched the default branch to 2.13.x, manually triggered the static analysis build, and Shepherd picked it up. Just need to update the README to display the badge for 3.1.x instead and merge the changes up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants