Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DebugStack logger in the test suite #4680

Merged
merged 1 commit into from Jun 18, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 18, 2021

Q A
Type improvement
BC Break no

The logger does not provide any value when it comes to diagnosing test failures. The primary assumption behind logging the stack of SQL statements is that their combination may be the root cause of an issue but in 100% of my experience with the test suite it's not true. Furthermore, when it comes to running tests in some new environment (e.g. against a new PHP version), massive test failures are expected but the details provided by the logger just create additional noise.

We may consider removing this logger entirely or moving to another higher-level library (e.g. DoctrineBundle).

@morozov morozov merged commit 4c1a55f into doctrine:3.1.x Jun 18, 2021
48 checks passed
@morozov morozov deleted the disable-debug-stack-logger branch Jun 18, 2021
@morozov morozov added this to the 3.1.1 milestone Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants