docs: fix docs for the json type#5022
Merged
Merged
Conversation
stof
approved these changes
Nov 25, 2021
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 25, 2021
…dunglas) This PR was merged into the 4.4 branch. Discussion ---------- [DoctrineBridge] Revert " add support for the JSON type" This reverts commit 1e218c5. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT | Doc PR | n/a As pointed out by @stof and @fancyweb on Slack, my patch is not in sync with Doctrine's code. Contrary to what is stated in the docs, Doctrine allows (almost) any PHP type to be stored as JSON. I also fixed the documentation of Doctrine: doctrine/dbal#5022 Commits ------- a1e22dc Revert "[DoctrineBridge] add support for the JSON type"
Member
Hey @dunglas 👋 ! I can't see where the docs state that, and you don't seem to change it in this PR 🤔 Is this PR missing something? Or am I? |
Member
|
@greg0ire that's the whole point: the existing documentation says that it always convert to |
Member
Ok, I thought that sentence was about encoding, but it might be interpreted as "You can get the same thing you set", which is indeed wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documentation of the
jsontype isn't in sync with the code. This PR fixes this.