Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix Connection Interface #521

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

jimlind commented Jan 29, 2014

PDOConnection passes a second variable into prepare.
The Interface should support it.

@jimlind jimlind Fix Connection Interface
PDOConnection passes a second variable into prepare.
The Interface should support it.
9c4275d

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-799

We use Jira to track the state of pull requests and the versions they got
included in.

Member

stof commented Jan 29, 2014

making the argument mandatory is a BC break. And your PR is broken, because it changes the interface without changing the implementation (hence a bunch of fatal errors in the testsuite).

#517 is doing the change the right way

Member

deeky666 commented Jan 29, 2014

Closing this in favour of PR #517.

@deeky666 deeky666 closed this Jan 29, 2014

jimlind commented Jan 29, 2014

My mistake.
It was late.
Sorry for wasting your time.

Member

deeky666 commented Jan 29, 2014

nevermind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment