Add close() method in MasterSlaveConnection.php #526

Merged
merged 1 commit into from Feb 11, 2014

Conversation

Projects
None yet
3 participants
@gohiei
Contributor

gohiei commented Feb 11, 2014

MasterSlaveConnection would use parent::close() to close connection, and it would close master connection, but slave connection.

That will increase the sqlite connections, and occur the "too many open files" error when I run our test.

@doctrinebot

This comment has been minimized.

Show comment Hide comment
@doctrinebot

doctrinebot Feb 11, 2014

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-810

We use Jira to track the state of pull requests and the versions they got
included in.

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-810

We use Jira to track the state of pull requests and the versions they got
included in.

guilhermeblanco added a commit that referenced this pull request Feb 11, 2014

Merge pull request #526 from gohiei/master
Add close() method in MasterSlaveConnection.php

@guilhermeblanco guilhermeblanco merged commit 594e326 into doctrine:master Feb 11, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment