Added result caching for QueryBuilder

[twoleds]

Q	A
Type	improvement
Fixed issues

Summary

Added enable/disableResultCache method in QueryBuilder for result caching.

I use doctrine/dbal in several projects and the result caching is annoying. Only way I can use result caching is calling executeCacheQuery method in Connection. I cannot use fetch* methods in QueryBuilder.

I repeat this piece of code:

$builder = $connection->createQueryBuilder();
// ....
$result = $connection->executeCacheQuery(
    $builder->getSQL(),
    $builder->getParameters(),
    [],
    new \Doctrine\DBAL\Cache\QueryCacheProfile($cacheLifetime)
)->fetchAllAssociative();

With this improvement it will be:

$builder = $connection->createQueryBuilder();
// ....
$builder->enableResultCache(300)->fetchAllAssociative();

What do you think about it? Is it possible to implement something like that?

[morozov]

@twoleds please rebase your branch on top of 3.4.x. The default 3.3.x branch accepts only bug fixes.

[morozov]

Looks good. Good work @twoleds! I'll let the PR hang for a bit more in case anybody has feedback.

[greg0ire]

Is there documentation to update?

[morozov]

Yeah, a section on caching could added to this document:

dbal/docs/en/reference/query-builder.rst

Line 1 in d6aaae9

SQL Query Builder

[twoleds]

I provided some documentation for the query builder, but my English is not so good, please check it if I wrote it correct.

The link has been added.

[morozov]

Thanks, @twoleds!

[twoleds]

Thanks for help to everyone, it was an interesting exprerience for me, I'm very happy that we have reached a successful end. Life will be a little bit easier. ❤️

[rvanlaak]

This feature is so cool, thank you for your contribution @twoleds ! 👏