GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Different implementation of the date/time manipulation functions so that those are no more limited to days and months intervals in PostgreSQL without impacting over DBMS (and can be improved later by developers with sufficient skills on the other DBMS)
This pull request should be associated with the one i sent on the doctrine main lib.
Different implementation of the date/time manipulation functions so t…
…hat those are no more limited to days and months intervals in PostgreSQL without impacting over DBMS (and can be improved later by developers with sufficient skills on the other DBMS)
please fix the indentation. You should use spaces, not tabs
what is $unit ?
same issues for this method
same issues here. The indentation is wrong and $unit is undefined
Another point: DBAL is stable so the BC should be kept. So you should not remove the previous methods
Corrections in DateAdd and DateSub functions on MySQL, Oracle and SQL…
I have made the corrections you requested : sorry for the tabs (bad config of my editor) and for the evil cut and paste (i have not other DBMS than PostgreSQL to test).
I have a question about the BC of DBAL : the functions i have removed are no more called and are in the platform specific implementations, not in the "public interface" of the library so they should not be called directly, should they ?
DBAL is not only for the ORM. It is a separate project that may be used by other people outside the ORM. Also, the platforms are part of the public interface as they are the way to get the needed SQL to be cross-platform.
Ok, thanks for the explanation. I get back those functions right now.
Brings back the AddDays, AddMonths, SubDays and SubMonths functions
Functions that handle intervals are renamed to avoid conflicts with e…
…xisting functions of the DBAL
Did you run the tests with this? I suppose they fail now.
Also what does this patch achieve? It seems to me really nothing by default. DBAL is about abstracting database differences, and I think only day and month can be done by all of them.
Mise à jour à la dernière version de DBAL
Closing this as the common denominator between all DBAL supported RDMSes seems to be date function with day and month.