Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

MsSqlPlatform - doModifyLimitQuery() generates incorrect SELECT query when using SELECT DISTINCT #68

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

On MSSQL platform the correct syntax is SELECT DISTINCT TOP ... , the current implementation of doModifyLimitQuery() ignores the DISTINCT keyword which results in the incorrect query - ie SELECT TOP DISTINCT ...

I have added a check for the DISTINCT keyword which corrects this issue

Member

deeky666 commented Nov 5, 2013

MsSqlPlatform doesn't exist anymore due to refactoring of the SQL Server platforms. Furthermore the doModifyLimitQuery() method has been updated several time in the meantime and is completely different now. If the issue is still present with current logic, please don't hesitate making a new PR.

@deeky666 deeky666 closed this Nov 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment