[DBAL-1024] Add more foreign key constraint violation error codes #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1024 We use Jira to track the state of pull requests and the versions they got |
|
|
||
| class ExceptionTest extends \Doctrine\Tests\DbalFunctionalTestCase | ||
| { | ||
| public function setUp() | ||
| private static $running = false; |
There was a problem hiding this comment.
Not sure why a static var is needed here: please look into it
Ocramius
added a commit
that referenced
this pull request
Nov 5, 2014
[DBAL-1024] Add more foreign key constraint violation error codes
|
@deeky666 this breaks the build: considering reverting it :-\ |
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver exception conversion was missing some error codes for foreign key constraint violations. Currently only foreign key constraint violations for
DELETEstatements are tested. Foreign key constraint violations can also occur forINSERT,UPDATEandTRUNCATEwrite operations where some platforms provide dedicated error codes for.