DDC-5: Remove unsigned/fixed #1582

Closed
doctrinebot opened this Issue Sep 14, 2009 · 4 comments

1 participant

@doctrinebot

Jira issue originally created by user romanb:

Changeset 6348 introduced unsigned/fixed properties for column metadata. Unsigned is completely unportable and fixed is unnecessary (we could simply introduce a fixed string type for this).

These 2 properties need to be removed.

@doctrinebot

Comment created by 'romanb':

[Comment from guilhermeblanco:]

Ok, perfect!

We could easily drop it. But I'd also suggest that we simplify the SchemaManagers?, since it does a lot of weird things (looks like an imported piece of 1.X code) to return a better handled (and more useful) information for us.

Also... we should even consider moving that piece of code to ORM, since it's an ORM specific information (converts DBAL datatypes to ORM datatypes).

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by 'rsauvat_inet':

Sorry to comment on an old bug but I have a problem. I understand why you want to remove the unsigned property and you proposed to remove the fixed property and implement a fixedstring type. But the problem is you removed the fixed property without implementing the new type so with Doctrine 2 it is not possible to create CHAR columns instead of VARCHAR which is different performance and storage wise in the database.

@doctrinebot

Comment created by '@beberlei':

You can, use the columnDefinition http://www.doctrine-project.org/docs/orm/2.0/en/reference/annotations-reference.html#annref-column or just define your own type.

@doctrinebot doctrinebot added this to the 2.0-ALPHA2 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment