Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-1136: Prevent backup files to be recognized as valid Entity files #1735

Closed
doctrinebot opened this issue May 5, 2011 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@doctrinebot
Copy link

Jira issue originally created by user fabpot:

The Doctrine2 generator backup Entity files when it adds code into them. The files are named after the original file with a prepended.

The problem is that these backup files are valid PHP files, and as such, they are loaded by Doctrine2. A PHP fatal error is then fired: "Cannot redeclare class...".

Instead of prepending , why not appending , which is a well supported convention? (foo.php vs ~foo.php)

Patch is here: #35

@doctrinebot
Copy link
Author

Comment created by @beberlei:

Applied and merged to 2.0.x

@doctrinebot
Copy link
Author

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.0.5 milestone Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants