Skip to content

Loading…

DDC-1148: [Patch] Auto infer parameter type in DQL #1748

Closed
doctrinebot opened this Issue · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @guilhermeblanco:

Here is the patch:

http://pastie.org/1891023
http://pastie.org/1891030

@doctrinebot

Comment created by @beberlei:

instanceof DateTimeZone is just wrong. drop that whole branch, TZ only saves the timezone from a DateTime object, infering TYPE::DECIMAL sounds dangerous to me, i would drop that one aswell. The array check has a bug, you call key() and then do nothing with the $key instaed check is_integer on the $value again, which is always an array from the previous check.

@doctrinebot

Comment created by @beberlei:

I thought you wanted to infer the types from the left hand sides of the DQL conditions?

@doctrinebot

Comment created by @guilhermeblanco:

Implemented: 8e3fdc5

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.1 milestone
@doctrinebot doctrinebot closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.