DDC-1192: fix undefined variable in join-column section of xml driver #1797

Closed
doctrinebot opened this Issue Jun 3, 2011 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user mvrhov:

$name is undefined, It might be that the fix is as simple as foreach ($manyToOneElement->{'join-columns'}->{'join-column'} as $name => $joinColumnElement) {
but I'm not sure

if (isset($manyToOneElement->{'join-column'})) {
    $joinColumns[] = $this->_getJoinColumnMapping($manyToOneElement->{'join-column'});
} else if (isset($manyToOneElement->{'join-columns'})) {
    foreach ($manyToOneElement->{'join-columns'}->{'join-column'} as $joinColumnElement) {
        if (!isset($joinColumnElement['name'])) {
            $joinColumnElement['name'] = $name;
        }
        $joinColumns[] = $this->_getJoinColumnMapping($joinColumnElement);
    }
}
@doctrinebot

Comment created by @beberlei:

This is a copy paste error from the YAML Driver, i fixed it.

@doctrinebot

Issue was closed with resolution "Fixed"

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0.6 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment