DDC-135: With/on extra join clauses are not yet processed properly by SqlWalker #1967

Closed
doctrinebot opened this Issue Nov 10, 2009 · 11 comments

2 participants

@doctrinebot

Jira issue originally created by user reinier.kip:

Reference thread: http://groups.google.com/group/doctrine-user/browse_thread/thread/5f3e01818cf30878

Criteria specified with QueryBuilder::leftJoin() do not appear in the native query. Looks like the with/on extra join clauses are not yet processed

properly by the SqlWalker that constructs the SQL+parameters.

@doctrinebot

Comment created by @guilhermeblanco:

They talk about the same thing.

@doctrinebot

Comment created by @beberlei:

Patch that fixes both DDC-135 but restricts it by the assumptions of DDC-177, namely not allowing to fetch join a LEFT JOIN .. ON/WITH clause

@doctrinebot

Comment created by romanb:

@Benjamin: Thats a good start but its not yet what its supposed to be. WITH appends* to the join condition whereas ON *overrides it. In the patch I only see ON implemented and it behaves like WITH.

@doctrinebot

Comment created by romanb:

I see you implemented WITH also, but they are supposed to produce different SQL. ON overrides, WITH appends.

@doctrinebot

Comment created by romanb:

@Benjamin: Btw. I think we should only implement WITH for now. ON is a bit too scary for me and I'd like to see more usecases first.

@doctrinebot

Comment created by @beberlei:

Ah now i understand, i didn't get the difference ;-)

I will strip down the patch to WITH then and handle it appropriately

@doctrinebot

Comment created by @beberlei:

The way i implemented ON it worked as WITH anyways.

@doctrinebot

Comment created by @beberlei:

Fixed, WITH clauses are processed correctly now. ON clauses throw an exception.

@doctrinebot

Issue was closed with resolution "Fixed"

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.0-BETA1 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment