Skip to content

Loading…

DDC-1810: [GH-347] Hydrator hotfix - time to think about keeping types for columns #2467

Closed
doctrinebot opened this Issue · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of rivaros:

Url: #347

Message:

Line 251 - nobody cared to call convertToPHPValue($value, $this->_platform);

And I know why - it was hard to determine column type, easier to write $value. :)

... Because type is not in ResultSetMapping

... Because type is not in ClassMetadataInfo either

... Because column types are never considered in associations.

@doctrinebot

Issue was closed with resolution "Won't Fix"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-347] was closed:
doctrine/dbal#347

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-347] was assigned:
doctrine/common#347

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-347] was closed:
doctrine/common#347

@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.