DDC-182: Changing entity in preUpdate hook tramples existing changes #2477

Closed
doctrinebot opened this Issue Nov 28, 2009 · 3 comments

1 participant

@doctrinebot

Jira issue originally created by user amirabiri:

If the object is changed during the pre-update callback, this causes the previous changes to be discarded.

Steps to reproduce:

  • Create entity with pre-update lifecycle callback
  • Change property A,
  • Call flush.
  • Change property B in pre-update callback

Result is that changes to property A are discarded.

The reason for that is that at the end of Doctrine\ORM\UnitOfWork::_computeEntityChanges() these two statements appear:

$this->_entityChangeSets[$oid] = $changeSet;
$this->_originalEntityData[$oid] = $actualData;

However at the end of Doctrine\ORM\UnitOfWork::computeSingleEntityChangeSet(), which is called after the pre-update callbacks are called, the same thing happens:

$this->_entityChangeSets[$oid] = $changeSet;
$this->_originalEntityData[$oid] = $actualData;

Because the original data is recorded as equal to the state of the object after the first call to _computeEntityChanges(), the call to computeSingleEntityChangeSet() does not detect the original set of changes, it only detects the changes made in the pre-update hooks. But at the same time, both methods completely overwrite the changeset buffer for the entity rather than merge it. The result is that the first changeset is completely discarded.

@doctrinebot

Comment created by romanb:

Are you sure this is still a valid issue? See DDC-74. This sounds like the same thing.

@doctrinebot

Comment created by amirabiri:

You are right and I'm sorry. I only went over the list of outstanding issues to avoid double-reporting, didn't occur to me this might have been fixed already.

@doctrinebot

Issue was closed with resolution "Duplicate"

@doctrinebot doctrinebot added this to the 2.0-ALPHA4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment