DDC-1893: Doctrine\ORM\Mapping\Driver\AnnotationDriver::create() not updated for new annotation readers #2558

Closed
doctrinebot opened this Issue Jun 26, 2012 · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user vasekpurchart:

After refactoring of annotation readers, there are new defaults and the current implementation calls undefined method, because Doctrine\Common\Annotations\AnnotationReader has been refactored too. The new way should be probably requiring Doctrine\Common\Annotations\Reader interface as $reader parameter and if not present constructing the default as in Doctrine\ORM\Configuration::create :

AnnotationRegistry::registerFile(DIR . '/Mapping/Driver/DoctrineAnnotations.php');

$reader = new \Doctrine\Common\Annotations\SimpleAnnotationReader();
$reader->addNamespace('Doctrine\ORM\Mapping');
$reader = new \Doctrine\Common\Annotations\CachedReader($reader, new ArrayCache());

@doctrinebot

Comment created by @ocramius:

Looking into this today

@doctrinebot

Comment created by @beberlei:

$config->newDefaultAnnotationDriver should have a flag for picking the simple or the "ORM\" prefixed reader

@doctrinebot

Comment created by @ocramius:

Handled in DDC-1915 (#396)

@doctrinebot

Issue was closed with resolution "Fixed"

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.3 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment