DDC-1934: version_compare behavior #2604

Closed
doctrinebot opened this Issue Jul 18, 2012 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user dattaya:

Note that version number with upper-case letters is not a correct PHP-standardized version number. Because of that the version_compare function might not work as you expected.
Examples:
vardump(versioncompare('2.1.0-dev', '2.1.0-beta', '<')); // expected: true
vardump(versioncompare('2.1.0-DEV', '2.1.0-BETA', '<')); // expected: true
vardump(versioncompare('2.1.0-DEV', '2.1.0-dev', '<')); // expected: false

Output:
bool(true)
bool(false)
bool(true)

I've seen in the code version_compare checks such as
version_compare(\Doctrine\Common\Version::VERSION, '2.2.0-DEV', '>=')
It's not big deal 'cause for example 2.2.0 is still > 2.2.0-DEV as well as 2.2.1, etc.

See also https://bugs.php.net/bug.php?id=62586

@doctrinebot

Comment created by @asm89:

As far as I can see it works for our use case. If you are experiencing real world problems feel free to re-open the issue.

@doctrinebot

Issue was closed with resolution "Won't Fix"

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment