Skip to content

DDC-2135: Setting column defaults using options in the annotations causes redundant alter statements #2823

Closed
doctrinebot opened this Issue Nov 9, 2012 · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user ccomer:

When using the Column annotation on an entity and passing the options parameter to set a default value for a column, the doctrine cli will generate the alter statement every time the schema-tool is run.

This doesn't break the functionality of updating the schema using the cli but when you have multiple entities using default values in this manner it becomes cumbersome to investigate issues during updates that fail and you need to dump the generated sql to examine.

Use case: We have a number of entities that include 'boolean' flags. The data for these entities is inserted into the database through an integration process handled by another application. For all of the flags we want to set a default value of 0 to avoid having to modify the integration scripts when a new flag is added to an entity and the data is not available yet.

Example entity:

/****
 * @ORM\Entity
 * @ORM\Table(name="example")
 */
class Example
{

    /****
     * @ORM\Id
     * @ORM\Column(type="integer")
     */
    protected $id;

    /*** @ORM\Column(type="integer", options={"default" = 0}) **/
    protected $disabled;

}
$ php bin/doctrine orm:schema-tool:update --dump-sql
ALTER TABLE example CHANGE disabled disabled TINYINT(1) DEFAULT '0' NOT NULL;

This alter statement is generated on every run of the schema-tool even though the schema has already been altered.

@doctrinebot

Comment created by @beberlei:

This is fixed for 2.3.4

@doctrinebot

Issue was closed with resolution "Duplicate"

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot added this to the 2.3.4 milestone Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.