DDC-2196: EntityManager can't be extended easily #2890

Closed
doctrinebot opened this Issue Dec 14, 2012 · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user mnapoli:

public static function create($conn, Configuration $config, EventManager $eventManager = null)
{
    // ...
    return new EntityManager($conn, $config, $conn->getEventManager());
}

The EntityManager::create method uses new on the EntityManager class instead of static.

This makes extending that class not practical because we have to rewrite (duplicate) EntityManager::create.

Code could be extendable with:

public static function create($conn, Configuration $config, EventManager $eventManager = null)
{
    // ...
    return new static($conn, $config, $conn->getEventManager());
}
@doctrinebot

Comment created by mnapoli:

Pull request is here: #535

@doctrinebot

Comment created by @beberlei:

Its not desired to override the EntityManager, we are currently building a PR to build a decorator for the EntityManager instead. You can decorate the EntityManager yourself.

@doctrinebot

Issue was closed with resolution "Invalid"

@doctrinebot

Comment created by mnapoli:

[~beberlei] Shouldn't it be final then?

@beberlei beberlei was assigned by doctrinebot Dec 6, 2015
@doctrinebot doctrinebot closed this Dec 6, 2015
@doctrinebot doctrinebot added the Bug label Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment