Skip to content

Loading…

DDC-2255: [Doctrine-Bridge][Console] Entity, Getters and Setters Generating Bug detected in Symfony 2 Framework #2955

Closed
doctrinebot opened this Issue · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user nayzo:

Bug found when generation the Entity, Getters and Setters by using the Command:

> php app/console doctrine:generate:entities YourBundleBundle:YourEntity 

In the situation you have a OneToMany* relation in the Entity and you did implement the __construct(), then the Console Wont generate the *ArrayCollection() !
In the case you did not implement the __construct(), then everything will goes fine when generating them,
Example:

/****
 * @ORM\OneToMany(targetEntity=" YourBundleBundle \Entity\ YourEntity ", mappedBy=" YourEntity ")
 */
private $YourAttribut;

public function **construct()
{
  $this-> YourAttribut = new \Doctrine\Common\Collections\ArrayCollection();
} 
// But in the case you did implement the **construct() before using the Command, let say like this:

public function **construct()
{
  $this-> YourOtherAttribut = a_value;
} 

In this case, when using the Command to generate Entity, Getters and Setters, the Console Wont* generate the ArrayCollection() of the OneToMany relations in the *__construct() !

@doctrinebot

Comment created by @ocramius:

[~nayzo] This is expected behavior, since the generator should not change already existing methods

@doctrinebot

Issue was closed with resolution "Invalid"

@doctrinebot

Comment created by nayzo:

but it could override them and add missing instruction that should be added within the code, otherwise it leads to a dis-function and non stable relations !!

@doctrinebot

Comment created by @ocramius:

No, that is not up to the generator. Entity generation and fixing your broken existing code are different things. You should not rely on the generator to handle this kind of problems, the generator just gives you a kick-start, but after that, you are on your own.

@Ocramius Ocramius was assigned by doctrinebot
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.