Skip to content

Loading…

DDC-2271: [GH-564] Fix a wrong return type #2970

Closed
doctrinebot opened this Issue · 4 comments

2 participants

@doctrinebot

Jira issue originally created by user @beberlei:

This issue is created automatically through a Github pull request on behalf of BenMorel:

Url: #564

Message:

BasicEntityPersister::executeInserts() is documented as:

@return array An array of any generated post-insert IDs. This will be an empty array
if the entity class does not use the IDENTITY generation strategy.

This PR fixes an empty return; that contradicted the documented return type.

@doctrinebot

Comment created by @beberlei:

A related Github Pull-Request [GH-564] was closed
#564

@doctrinebot

Comment created by @FabioBatSilva:

Merged : f0674ea

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot

Comment created by @doctrinebot:

A related Github Pull-Request [GH-564] was closed:
doctrine/dbal#564

@beberlei beberlei was assigned by doctrinebot
@doctrinebot doctrinebot added this to the 2.4 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.