Skip to content

Loading…

DDC-229: Changeset 6982 breakage #2990

Closed
doctrinebot opened this Issue · 2 comments

2 participants

@doctrinebot

Jira issue originally created by user romanb:

http://trac.doctrine-project.org/changeset/6982/

The new processDeferredExpressionsStack does not look good. It processes all expressions. Previously, each (sub)query had its own stack.

Now, when you do sth like this: "select u, (select max(o.id) from Other o) maxId from User u" you will trigger all validations at the end of the subquery. 'u' will be validated but is still undefined.

Please explain why the old behavior with one stack for each (sub)query was not preserved.

Also, things like

$method = '_validate' . $item['method']; 

lead to very fragile (bad) code.

@doctrinebot

Comment created by @guilhermeblanco:

Just a little mis-comprehension of the new way I've build expressions validations.
Resolving ticket.

@doctrinebot

Issue was closed with resolution "Fixed"

@doctrinebot doctrinebot added this to the 2.0-ALPHA4 milestone
@doctrinebot doctrinebot closed this
@doctrinebot doctrinebot added the Bug label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.